|
Post by Stefan on Dec 4, 2022 6:12:57 GMT -5
Looks like this one has been lurking, waiting to be found since at least v2.6.22217
A command like this works fine CHANGE ALL 'blue' 'BLUE'
but like this it doesn't.
CHANGE ALL C'blue' 'BLUE' ===> Msg Extra color name operand detected - Blue
[UPDATE]
Take the use of a colour (blue) as an example. The problem applies to any 'keyword' for the relevant FIND/CHNAGE, etc comand [/UPDATE]
|
|
|
Post by George on Dec 4, 2022 17:02:00 GMT -5
OK, go ahead and fetch the latest source, review and correct all the command parse code and return it to me and I'll be happy to swap it in.
I'll have a look, but you guys suggesting a review of all parse code, let alone changing and testing it as if it's some minor little chore is getting a bit much.
G.
|
|
|
Post by George on Dec 5, 2022 9:21:12 GMT -5
Robert: My apologies - a bad day.
No, I don't need help, I'm sure it's just the color parser missing an IsQuoted (or whatever it's called) to filter this out.
George
|
|
|
Post by George on Dec 5, 2022 10:16:31 GMT -5
OK, found it. The test for quoted strings was there, but only tested for simple quoted strings, forgetting that we have C'..', T'..', P, R etc.
George
|
|
|
Post by Stefan on Dec 5, 2022 13:22:46 GMT -5
With so many other useful enhancements and buglets around at the moment, the 'Trailing Type Codes' is not a feature I have ever missed or will ever miss. And compatibility with ISPF has its limits. I venture to suggest that SPFLite has departed so far from ISPF, that there are possibly more 'new' features in SPFlite now than were ever in the core of ISPF.
|
|
|
Post by George on Dec 5, 2022 14:38:14 GMT -5
Yeah, those trailing type codes are the epitome of 'code clutter' and I agree, I have never used them, probably never will, and I doubt anyone else would either.
George
|
|
|
Post by George on Dec 6, 2022 9:39:55 GMT -5
I wasn't suggesting removal, I was just pointing out the useless type of stuff that clutters up huge chunks of SPFLite code. You may never notice it, but I see it all the time going through code.
In the middle of some logical piece of code there will be some: IF this AND that AND something THEN fiddle something for some obscure reason END IF
All to ISPF'ize something; or handle some other not-quite-standard cursor positioning difference; or whatever.
And I daren't touch any of it because in a lot of cases the associated comments are no longer sufficient to describe just why the code was added in the first place.
George
|
|