|
|
Post by mueh on Nov 3, 2023 8:52:14 GMT -5
Hi George !
For those users having in OPT "Only 1 SPFLite running" not on
and use Primary command OPEN OPENV OPENB they get following problems .
OPEN cmd is treated as OPENLIST in ObjENV.inc
OPENV and OPENB open new default window in EDIT mode .
Mode should be correctly set when FMode is set to (OE) (OV) (OB) in ObjENV.inc .
Sub DoCloneSession needs change if OPEN cmd to start it as -OPENE in
lclMode = SWITCH$(lclPCmd = "OPEN", " -OPEN ", lclPCmd = "OPENV", " -OPENV ", lclPCmd = "OPENB", " -OPENB ")
and check for -OPENE in ObjENV.inc
ELSEIF cWord = LEFT$("-OPEN", LEN(CWord)) THEN ' An OPEN request?
FMode = "(OE)" ' Remember that
Thanks
JFYI : PCodeTable(030) = CODEPTR(PCmdOpen) seems to be never used by any cmd in ObjPCmdT.inc .
OPENx uses 028 .
|
|
|
|
Post by George on Nov 3, 2023 10:36:55 GMT -5
MUEH: Hmmm, maybe OPENLIST wasn't a good choice, too many collisions.
How about FILELIST or FILEOPEN and the INSTANCE operand woulf become -F
George
|
|
|
|
Post by mueh on Nov 3, 2023 11:09:46 GMT -5
George: FILELIST is fine for me but we should keep in mind that FILELIST directory where FLIST files are is something different .
|
|
|
|
Post by George on Nov 3, 2023 12:12:26 GMT -5
That's why I added FILEOPEN, to avoid that possibility.
George
|
|
|
|
Post by Robert on Nov 3, 2023 12:15:11 GMT -5
George, I believe this pointing out an issue in how you manage the SPFLite command-line arguments. You chose to honor any keyword as long as the first letter is a valid one. So, -OPENLIST and -ORANGUTAN work equally well.
Perhaps you should review the list of arguments, and choose (new) short values for all of them, but then make them all unique, so that this implied-abbreviation thing isn't done any more.
So, if you want to name the -OPENLIST as -FL instead, then you MUST use exactly -FL and nothing else.
R
|
|
|
|
Post by George on Nov 3, 2023 13:27:39 GMT -5
Robert: No, it doesn't just use the 1st letter. -OPENLIST and -ORANGUTAN are not the same, ORANGUTAN would be rejected. The tests are all coded as:
IF cWord = LEFT$("-INSTANCE", LEN(CWord)) THEN ' An INSTANCE request?
The problem was that OPEN/OPENV/OPENW/OPENLIST all started with OPEN.
It is a simple test that works well if collisions like the above are not created.
George
|
|
|
|
Post by mueh on Nov 3, 2023 13:50:41 GMT -5
Hi George!
-OPEN was never documented as a startup parameter . It's just used internaly by OPEN cmd .
So what prevents to use -OPENE instead of -OPEN in SWITCH on page 1 ?
OPEN cmd can still be used and -OPENLIST too .
Thanks
|
|
|
|
Post by George on Nov 3, 2023 15:25:30 GMT -5
MUEH: Yes, the OPENx operands were never documented, as there is really no practical use for them other than as support for the OPENx commands. So yes, you could code them, but to what end?
George
|
|
|
|
Post by George on Nov 4, 2023 11:38:30 GMT -5
OK, Beta 23308 posted. -O OPENLIST has been altered to -F FILEOPEN.
George
|
|
|
|
Post by mueh on Nov 5, 2023 9:54:17 GMT -5
Hi George !
When _FILEOPEN.TXT is created all File modes (E) are in upercase .
Maybe it's usefull to lower case it to (e) for Current Tab where INST U -F * KEEP is issued .
This would inherit the current tab to the now started instance .
Thanks
|
|
|
|
Post by Robert on Nov 5, 2023 10:36:15 GMT -5
So, putting session type-code (E,V,B) in lower-case would act as a "flag"? That way, the files would be opened, and the one with the lower-case code would be treated like you used LMB on the tab.
A little subtle, but it seems like it would work. Though, if I had my druthers, it would be something a little more explicit. Suppose, instead of lower-case, we used brackets instead of parens, so that it would be [E] instead of (E).
Just a thought.
R
|
|
|
|
Post by Robert on Nov 5, 2023 10:50:53 GMT -5
Another thought: Instead of (e) or [E] we could use * to mean "set as current tab", so it would look like (E*).
R
|
|
|
|
Post by George on Nov 5, 2023 12:12:19 GMT -5
Robert: All that Upper/Lower case stuff is in place and has been so since re-open recent files support was added, so no changes at this point.
MUEH: I'll check out adding that, but if the FILEOPEN list is concatenated to the MRF list then the last one procssed 'wins'.
George
|
|
|
|
Post by George on Nov 5, 2023 14:05:19 GMT -5
MUEH: Well, the code attempted to do that, but got itself waylaid by the logic that forces the actual execution of the INSTANCE command to be done in the File Manager tab. Should be OK in the next Beta.
George
|
|
|
|
Post by Robert on Nov 5, 2023 20:11:55 GMT -5
I'm not confused. Um ...
But in case I am, or if others are, I hope all these beta bug fixes are documented once the dust settles.
George, the direction that Instances has gone is much different than I had envisioned for Tasks. I hope you or Mueh could put a tutorial together to give some usage examples.
R
|
|
