Chained primary command not working as expected

samarye
New Member

Posts: 3

Chained primary command not working as expected Feb 10, 2021 10:33:41 GMT -5

Quote

Post by samarye on Feb 10, 2021 10:33:41 GMT -5

I have some experience with IBM MF ISPF and CTC's version. I am newly evaluating SPFLite. I am running 2.3.21026 on Win 10 x64.

The following primary command does not work as expected;

x all;f all watch;del all x

For example on the following lines;

www.youtube.com/
www.youtube.com/channel/UCEgdi0XIXXZ-qJOFPf4JSKw
www.youtube.com/account
www.youtube.com/watch?v=O83Y8oDPjW4
www.youtube.com/watch?v=n3b20MENkz0&t=187s
www.youtube.com/watch?v=IzcdUPaCBCw&t=18s
www.youtube.com/watch?v=-vJkk4Yu4hA
www.youtube.com/watch?v=lT2Eue5DX14
myaccount.google.com/u/0/b/112687887046609403533/?utm_source=YouTubeWeb&tab=rk&utm_medium=act&tab=rk&hl=en
www.youtube.com/channel/UCNMlpoKqVJkoYvmZ5QI_48g
www.youtube.com/paid_memberships?ybp=mAEK

The result should be;

www.youtube.com/watch?v=O83Y8oDPjW4
www.youtube.com/watch?v=n3b20MENkz0&t=187s
www.youtube.com/watch?v=IzcdUPaCBCw&t=18s
www.youtube.com/watch?v=-vJkk4Yu4hA
www.youtube.com/watch?v=lT2Eue5DX14

Instead, all lines are deleted.

If I break the command into two parts;

x all;f all watch
del all x

and run these separately, it does produce the correct output.

I'm not sure if the find command is picking up the ";del..." as part of the string to find, or what, but this is a common technique I have used on other SPFs and not had this issue;

- exclude everything
- find the lines I want to keep so they get non-excluded
- delete the remaining excluded lines

Last Edit: Feb 11, 2021 1:41:39 GMT -5 by samarye

George
Administrator

Posts: 4,062

Chained primary command not working as expected Feb 10, 2021 12:43:03 GMT -5 samarye likes this

Quote

Post by George on Feb 10, 2021 12:43:03 GMT -5

Hi,
What you're doing is, I'm sure, what any experienced ISPF user would (and has) done.

I couldn't believe it was 'broken' and had not been reported, but yes indeed somewhere along the way it has gotten corrupted.

Found and corrected it. If you like, I've attached a corrected version. Just swap it into the SPFLite install folder, you can leave it as SPFite23.EXE, or rename it to replace the original SPFLite2.EXE version - your choice.

Thanks for reporting it.

George

SPFLite23.exe (483 KB)

George
Administrator

Posts: 4,062

Chained primary command not working as expected Feb 10, 2021 14:56:19 GMT -5

Quote

Post by George on Feb 10, 2021 14:56:19 GMT -5

Robert: Didn't you see my post with a corrected version?

The problem was caused by how/when the routine that actually performs the changes to X'd lines was called. Command processor code simply alters the visibility of lines, and doesn't worry about inserting the - - - - - lines, or collapsing adjacent visible/invisible blocks into contiguous blocks.

For stacked commands, this routine has to be given a chance to 'do it's stuff' between each command - and it wasn't. Not sure just when this bug was introduced.

Can you give me some details on the Help file fix?

George

George
Administrator

Posts: 4,062

Chained primary command not working as expected Feb 10, 2021 16:24:35 GMT -5

Quote

Post by George on Feb 10, 2021 16:24:35 GMT -5

Robert: No, you're not nuts. It is rendered properly in the PDF and HTML versions of the Doc. I also went into HnD, and deleted and re-inserted the example. Built the CHM again, and it's still mucked up.

I may have to forward it to HnD to check out, they've always been very responsive, even with the free version.

I'll try a couple other variations first though.

George

samarye
New Member

Posts: 3

Chained primary command not working as expected Feb 11, 2021 1:38:46 GMT -5

Quote

Post by samarye on Feb 11, 2021 1:38:46 GMT -5

Feb 10, 2021 12:43:03 GMT -5 George said:

Found and corrected it.

That was quick.

I can confirm your fix worked almost as expected on my larger real data file, and the longer command;

x all;f all watch;del all x;sort uniq

did produce the desired data results.

The remaining more minor issue I have is with the red status messages in the upper right. If I execute my little test line by line, the messages are;

x all: "+Excluded 11 Lines"
f all watch: "CHARS watch found 5 times"
del all x: "Deleted 6 Lines"

When I run my test in chained command form, the message still says "+Excluded 11 Lines" afterwards. Perhaps that is as designed, but I would expect it to say "Deleted 6 Lines".

Similar, perhaps, to the original issue, the code to update that message doesn't seem to be being called with each separate command of a chained command.

Thanks.

Last Edit: Feb 11, 2021 8:18:17 GMT -5 by samarye

George
Administrator

Posts: 4,062

Chained primary command not working as expected Feb 11, 2021 10:51:00 GMT -5

Quote

Post by George on Feb 11, 2021 10:51:00 GMT -5

samarye: The SPFLite error message handling is not the same as ISPF, we don't have all the lovely multi-level help support that ISPF/PDF provided.

When only a single message is generated by a command, the message is simply displayed. When a command, or series of commands issues multiple commands, the last (or most severe - I forget) is displayed with a + added to the left end to indicate that multiple messages exist.

If F1 (Help) is entered immediately, a pop-up window will appear to display ALL the messages. If anything other that Help is entered, the messages are discarded.

Not the greatest way, but it has served it's purpose.

George

samarye
New Member

Posts: 3

Chained primary command not working as expected Feb 11, 2021 12:11:14 GMT -5

Quote

Post by samarye on Feb 11, 2021 12:11:14 GMT -5

Feb 11, 2021 10:51:00 GMT -5 George said:

the last (or most severe - I forget) is displayed with a + added to the left end to indicate that multiple messages exist.

Which I see is also what the help file says (and matches my expectation).
My only point was that is not what is happening, it is displaying the first message with the "+".
Thanks.

Last Edit: Feb 11, 2021 12:15:00 GMT -5 by samarye

George
Administrator

Posts: 4,062

Chained primary command not working as expected Feb 11, 2021 12:52:00 GMT -5

Quote

Post by George on Feb 11, 2021 12:52:00 GMT -5

samarye: Well, it could be the first because the messages were all issued with the same level error code.

When multiple messages are issued during a function, the one with the severest error code 'wins', so it IS possible that some other message might be the one seen with the +, but all are in the displayed list in the right order.

George