Somewhere within SET PENDING.xxx=Y and Get_Src_LCmd$....

Stefan
Administrator

Posts: 990

Somewhere within SET PENDING.xxx=Y and Get_Src_LCmd$.... Jan 13, 2022 11:17:37 GMT -5

Quote

Post by Stefan on Jan 13, 2022 11:17:37 GMT -5

Hi George,

I think an error has crept in that affects macros which expect to capture pending line commands.

I believe the functions Get_Src_LCmd$ and Get_Dest_LCmd$ no longer return any value.

I cannot tell you when the problem started, but I can confirm that all was well in v21149 (found on a 'forgotton-I-had-this' Samsung Netbook).

My recent versions only go back to v21289 and it was broken by then, as well as in all more recent versions.

One of my macros 'captures' any pending line commands using the code segment below, in order replace them after it has finished doing its 'thing'.

Problem is, it doesn't capture anything any more.

The SPF_DEBUG statements display only empty strings.

  '---------------------------------------------------------------------------------------          
  ' Capture details for any pending line commands                                                   
  ' Uses Line handles because line pointers/numbers may change during macro execution               
  '---------------------------------------------------------------------------------------          
  srcCmd$ = Get_Src_LCmd$                                                                           
  IF srcCmd$ <> "" THEN                          ' If there's a SOURCE line command                 
    src1Hnd$ = Get_Handle$(Get_Src1_Lptr)        '   Capture the line range                         
    src2Hnd$ = Get_Handle$(Get_Src2_Lptr)                                                           
  END IF                                                                                            
  dstCmd$ = Get_Dest_LCmd$                                                                          
  IF dstCmd$ <> "" THEN                          ' If there's a DESTINATION line command            
    dst1Hnd$ = Get_Handle$(Get_Dest1_Lptr)       '   Capture the line range                         
    dst2Hnd$ = Get_Handle$(Get_Dest2_Lptr)                                                          
  END IF                                                                                            
  SPF_Debug("BEFORE: srcCmd$=["+srcCmd$+"] handles are ["+src1Hnd$+"] ["+src2Hnd$+"]")              
  SPF_Debug("        dstCmd$=["+dstCmd$+"] handles are ["+dst1Hnd$+"] ["+dst2Hnd$+"]")

<Macro does its "thing" here>

                                                                                                    
  '---------------------------------------------------------------------------------------          
  ' Restore any line commands that were pending when LP macro started                               
  ' Remove the line handles (handles are persistent especially with STATE ON)                       
  '---------------------------------------------------------------------------------------          
  SPF_Debug("AFTER:  srcCmd$=["+srcCmd$+"] handles are ["+src1Hnd$+"] ["+src2Hnd$+"]")              
  SPF_Debug("        dstCmd$=["+dstCmd$+"] handles are ["+dst1Hnd$+"] ["+dst2Hnd$+"]")              
  IF srcCmd$+dstCmd$ <> "" THEN                                                                     
    IF srcCmd$ <> "" THEN                        ' If there were SOURCE line command(s)             
      SPF_Cmd("LINE "+srcCmd$+" "+src1Hnd$)      '   Re-place on the relevant line(s)               
      SPF_Cmd("LINE "+srcCmd$+" "+src2Hnd$)                                                         
      temp$ = Drop_Handle$(src1Hnd$)             '   Drop the associated line handles               
      temp$ = Drop_Handle$(src2Hnd$)                                                                
    END IF                                                                                          
    IF dstCmd$ <> "" THEN                        ' If there were DEST line command(s)               
      SPF_Cmd("LINE "+dstCmd$+" "+dst1Hnd$)      '   Re-place on the relevant line(s)               
      SPF_Cmd("LINE "+dstCmd$+" "+dst2Hnd$)                                                         
      temp$ = Drop_Handle$(dst1Hnd$)             '   Drop the associated line handles               
      temp$ = Drop_Handle$(dst2Hnd$)                                                                
    END IF                                                                                          
  END IF                                                                                            
                                                                                                    
  Halt(G_myRC,G_msg$)

Last Edit: Jan 13, 2022 11:18:49 GMT -5 by Stefan

George
Administrator

Posts: 4,056

Somewhere within SET PENDING.xxx=Y and Get_Src_LCmd$.... Jan 13, 2022 16:43:15 GMT -5

Quote

Post by George on Jan 13, 2022 16:43:15 GMT -5

Stefan: I can count on you to come up with something like this. So 21149 works, and subsequent versions don't. Should be interesting, I can't recall changes that would affect this, but obviously something did.

I'll get back.

George

George
Administrator

Posts: 4,056

Somewhere within SET PENDING.xxx=Y and Get_Src_LCmd$.... Jan 13, 2022 16:48:02 GMT -5

Quote

Post by George on Jan 13, 2022 16:48:02 GMT -5

Stefan:
OK, from this side it all looks OK.

I wrapped your sample code to make a complete macro. It now looks like:

StMacErr.macro (2.49 KB)

The only real change I made was to add a test and only do the Drop_Handle for src2 and dst2 if they differ from src1/dst1. Otherwise the 2nd Drop_Handle will fail as the handle is already freed.

My debug trace looks like this (which seems to show everything OK)

I'm sure you DO have a problem, what am I missing?

George

Stefan
Administrator

Posts: 990

Somewhere within SET PENDING.xxx=Y and Get_Src_LCmd$.... Jan 14, 2022 5:09:35 GMT -5

Quote

Post by Stefan on Jan 14, 2022 5:09:35 GMT -5

George,

Thanks for the improvements in the 'restore line commands' section. Good spot.

That issue is really bizarre!

My original macro runs fine on v21149 but fails on current release and beta versions.

The weird thing is - the same applies to your StMacErr macro.

(Just to be clear - I copied only the v21149.EXE to my live environment. So it was using the v23003 CFG file. And it all worked.)

Here's the trace from your StMacErr.macro executed on each version.

v21149.EXE returns values, v22003.EXE doesn't.

I'll retried v23003.EXE with a virgin CFG.

Now both my and your macros work as they should and I see the same trace as you did from the StErrMac on v22003.

So the issue is my CFG. Clearly SPFLite isn't happy with it.

I'll add back my CFG configuration components one by one and see if/when it breaks.

First addition - make the MACRO profile the same as before. The settings changed were things like AUTOCAPS, AUTOSAVE, MINLEN, etc and profile LOCK - ie. all unrelated.

Reran stMacErr.

Ok... interesting finding...

The virgin CFG file does NOT yet have the SET PENDING.StMacErr=Y flag.

Nevertheless, StMacErr macro executed and did so correctly despite pending line commands being present. (Surprised!)

I added the above PENDING.StMacErr=Y flag and the macro failed.

I'm officially confused!

Last Edit: Jan 14, 2022 5:48:52 GMT -5 by Stefan

George
Administrator

Posts: 4,056

Somewhere within SET PENDING.xxx=Y and Get_Src_LCmd$.... Jan 14, 2022 11:27:34 GMT -5

Quote

Post by George on Jan 14, 2022 11:27:34 GMT -5

Stefan: OK tested with/without the pending=y and found it. It now works properly both ways. I still don't have a clue what change triggered this, but even a quick look at the IF/ELSE/IF ... structure involved waved big red flags saying "Me! Me!"

I'll get a Beta out soon.

George