Macro: Issue with GET_RBOUND function

Stefan
Administrator

Posts: 990

Macro: Issue with GET_RBOUND function Jan 14, 2024 6:51:45 GMT -5

Quote

Post by Stefan on Jan 14, 2024 6:51:45 GMT -5

George,

My LP.MACRO doesn't work if the user has BOUNDS set to a range which prevents LP finding the start of procedures. methods, etc.

So I added

GLOBAL AS NUMBER gLBnd = Get_LBound ' Currently active BOUNDS
GLOBAL AS NUMBER gRBnd = Get_Rbound

SPF_Cmd("BOUNDS 1 MAX") ' Remove any BOUNDS restrictions

at the start and

IF gLBnd <> 1 OR gRBnd <> 0 THEN _ ' Reset the original BOUNDS values
SPF_Cmd("BOUNDS "+gLBnd+" "+gRBnd)
before the macro ends.

Problem: The IF statement at the end is always true and resets the BOUNDS to 1 <length-of-longest-line>

This little macro illustrates that Get_Rbound does not perform as documented.

If BOUNDS 1 MAX is in effect, Get_RBound should return a value of 0, but it returns <length-of-longest-line> instead

The status line then reflects the constraint which is carried forward for this sesssion and possibly beyond via an unlocked profile

To illustrate:

' SN.MACRO                                                                                          
  DIM AS NUMBER lBnd = Get_LBound                    ' Currently active left BOUNDS                     
  DIM AS NUMBER rBnd = Get_Rbound                    ' Currently active right BOUNDS                    
  SPF_CMD("CLS")                                                                                    
  SPF_TRACE(ON)                                                                                       
  SPF_Debug("Captured Bounds:          "+lBnd+" "+rBnd)                                                            
  SPF_DEBUG("------")                                                                                     
  SPF_Cmd("BOUNDS 1 MAX")                            ' Remove any BOUNDS restrictions                   
  lBnd = Get_LBound                                                                                 
  rBnd = Get_Rbound                                                                                 
  SPF_Debug("Should be 1 0   now:      "+lBnd+" "+rBnd)                                                            
  SPF_DEBUG("------")                                                                                     
  IF lBnd <> 1 OR rBnd <> 0 THEN _                   ' Reset the original BOUNDS values                 
    SPF_Cmd("BOUNDS "+lBnd+" "+rBnd)                                                                
  SPF_Debug("Should equal Captured:    "+lBnd+" "+rBnd)                                                            
  HALT

Robert
Graduate Member

Posts: 3,151

Macro: Issue with GET_RBOUND function Jan 14, 2024 10:04:41 GMT -5

Quote

Post by Robert on Jan 14, 2024 10:04:41 GMT -5

I used a simpler macro, and tested it on itself (on the test.macro file) with BNDS MAX on the status bar:

' test.macro             
halt ("Get_Rbound", Get_Rbound)

When I run this, I get a message of "Get_Rbound 31", and the right ")" on the HALT statement in is column 31.

As Stefan noted, Help for this function says, "If the right bounds is MAX, 0 (zero) is returned" but that's not what happens.

R

George
Administrator

Posts: 4,056

Macro: Issue with GET_RBOUND function Jan 14, 2024 10:16:23 GMT -5

Quote

Post by George on Jan 14, 2024 10:16:23 GMT -5

Stefan: Yes, there was something odd in Get_RBounds. If RBound was 0 (MAX) it was returning the length of the maximum length line. I don't know why, it is not documented that way. I removed that and got it back to working.

I altered your test macro a bit. It wasn't really restoring the original BNDS setting.

Here it is:

' SN.MACRO
  SPF_CMD("CLS")
  SPF_TRACE(ON)
  DIM AS NUMBER olBnd = Get_LBound                   ' Original active left BOUNDS
  DIM AS NUMBER orBnd = Get_Rbound                   ' Original active right BOUNDS
  DIM AS NUMBER lBnd                                 ' Currently active left BOUNDS
  DIM AS NUMBER rBnd                                 ' Currently active right BOUNDS
  SPF_Debug("Captured Bounds:          "+olBnd+" "+orBnd)
  SPF_DEBUG("------")
  SPF_Cmd("BOUNDS 1 MAX")                            ' Remove any BOUNDS restrictions
  lBnd = Get_LBound
  rBnd = Get_Rbound
  SPF_Debug("Should be 1 0   now:      "+lBnd+" "+rBnd)
  SPF_DEBUG("------")
  IF olBnd <> 1 OR orBnd <> 0 THEN _                 ' Reset original if not BNDS 1 MAX
    SPF_Cmd("BOUNDS "+olBnd+" "+orBnd)
  lBnd = Get_LBound
  rBnd = Get_Rbound
  SPF_Debug("Should equal Captured:    "+lBnd+" "+rBnd)
  HALT

Stefan
Administrator

Posts: 990

Macro: Issue with GET_RBOUND function Jan 14, 2024 18:03:51 GMT -5

Quote

Post by Stefan on Jan 14, 2024 18:03:51 GMT -5

Good spot!
The code was a fusion of the two DIM stmts and the IF... sequence originally lifted from LP.MACRO, and various SPF_DEBUG stmts.
Just goes to show - doesn't matter how simple we make it, there's always an opportunity to mess it up.

Thanks for restoring Get_Rbound to normal behaviour.

Last Edit: Jan 14, 2024 18:04:17 GMT -5 by Stefan